Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenameForeachValueVariableToMatchExprVariableRector removes underscores #6479

Closed
JoosuaKoskinen opened this issue Jun 2, 2021 · 0 comments · Fixed by rectorphp/rector-src#236
Closed

RenameForeachValueVariableToMatchExprVariableRector removes underscores #6479

JoosuaKoskinen opened this issue Jun 2, 2021 · 0 comments · Fixed by rectorphp/rector-src#236
Labels
bug

Comments

@JoosuaKoskinen
Copy link

Bug Report

Subject Details
Rector version e.g. v0.11.5

RenameForeachValueVariableToMatchExprVariableRector unnecessarily removes underscores from variable names.

Minimal PHP Code Causing Issue

https://getrector.org/demo/3844d1cc-9ee3-4f98-8259-4edea12b09d7

Expected Behaviour

It shouldn't remove underscores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Naming] Keep underscore in RenameForeachValueVariableToMatchExprVariableRector rectorphp/rector-src
1 participant
@JoosuaKoskinen