Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rector hangs with no output #7889

Closed
nerones opened this issue Apr 19, 2023 · 0 comments · Fixed by rectorphp/rector-src#3639
Closed

Rector hangs with no output #7889

nerones opened this issue Apr 19, 2023 · 0 comments · Fixed by rectorphp/rector-src#3639
Assignees
@samsonasik
Labels
bug

Comments

@nerones
Copy link

nerones commented Apr 19, 2023 •
edited
Loading

Bug Report

Subject Details
Rector version Rector 0.15.24

I'm trying to update the php version for a legacy project written in cackephp 2, rector seems to hang on some files, it's very hard to debug. But after disabling the parallel execution I was able to found the problematic file.

Minimal PHP Code Causing Issue

https://getrector.com/demo/289e4c81-adae-4062-8a7a-2ad51c53c711

Expected Behaviour

I'm not sure on how this file should be changed but rector should not hang.
@nerones nerones added the bug label Apr 19, 2023
@samsonasik samsonasik self-assigned this Apr 20, 2023
samsonasik added a commit to rectorphp/rector-src that referenced this issue Apr 20, 2023
@samsonasik
Closes rectorphp/rector#7889
a34ea58
@samsonasik samsonasik mentioned this issue Apr 20, 2023
Merged
samsonasik added a commit to rectorphp/rector-src that referenced this issue Apr 20, 2023
@samsonasik @actions-user
[Php56][Php70] Handle infinite loop on TernaryToNullCoalescingRector+…
8425c90 
…AddDefaultValueForUndefinedVariableRector (#3639)

* reproduce hang

* Closes rectorphp/rector#7889

* clean up

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>
samsonasik added a commit to rectorphp/rector-src that referenced this issue May 8, 2023
@samsonasik @actions-user
[Php56][Php70] Handle infinite loop on TernaryToNullCoalescingRector+…
c6b0d22 
…AddDefaultValueForUndefinedVariableRector (#3639)

* reproduce hang

* Closes rectorphp/rector#7889

* clean up

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsonasik samsonasik

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@nerones @samsonasik