[Php56][Php70] Handle infinite loop on TernaryToNullCoalescingRector+AddDefaultValueForUndefinedVariableRector #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 🎉 /cc @nerones |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
@TomasVotruba I am merging it ;) |
staabm
reviewed
Apr 20, 2023
| return true; | ||
| } | ||
|
|
||
| if ($this->isAsCoalesceLeftOrAssignOpCoalesceVar($parentNode, $variable)) { | ||
| if ($this->issetOrUnsetOrEmptyParent($parentNode)) { |
There was a problem hiding this comment.
@samsonasik I think it could make sense to re-order the skipchecking methods so e.g. doing AST traversing only after cheaper checks have been done
There was a problem hiding this comment.
This patch is to ensure no infinite loop by check coalesce early, which check coalesce later cause infinite loop, see https://getrector.com/demo/289e4c81-adae-4062-8a7a-2ad51c53c711
feel free to provide improvement PR 👍
|
Amazing job, thanks. I really like this tool I hope that at some point I will able to contribute something. |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…AddDefaultValueForUndefinedVariableRector (#3639) * reproduce hang * Closes rectorphp/rector#7889 * clean up * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#7889
Ref https://getrector.com/demo/289e4c81-adae-4062-8a7a-2ad51c53c711