[RHDHPAI-984] Update for LCS categories field in feedback #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Jdubrick
requested review from
JslYoon,
maysunfaisal,
michael-valdron,
thepetk and
yangcao77
maysunfaisal
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Lightspeed Core introduces a new field related to feedback,
categories. This field is intended to be used alongside a thumbs down (sentiment=-1) response. You can read more about this field here.These changes update the harvester to properly handle that field and write it to the database if required, additionally, the Postgres deployment is updated to have that field adde to the
feedbacktable.Also refactored the logging for the validation function when creating a Feedback object for writing to the DB
Note: This is an optional field and during my testing I confirmed that these changes to Postgres will not affect you if you are using Road Core still as they are fully compatible.
The changes for the harvester have been built and pushed to
quay.io/redhat-ai-dev/feedback-harvester:latest, this new tag will not affect anyone using it previously as that was taggedv0.1.0as that corresponds to the release for dev preview.Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHDHPAI-984
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: