#RI-3751-add command execution time #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1_command_execution_time
…disearch Feature/ri 2831 browser redisearch
…ub.com/RedisInsight/RedisInsight into feature/RI-3751_command_execution_time
…ub.com/RedisInsight/RedisInsight into feature/RI-3751_command_execution_time
ArtemHoruzhenko
requested changes
Nov 3, 2022
| if (executionTimeInNanoseconds !== 0) { | ||
| commandExecution.executionTime = Math.round(executionTimeInNanoseconds / 1000); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure that using hrtime() is a correct way here.
At first it is legacy function - https://nodejs.org/api/process.html#processhrtimetime. If you want to use use node:process then you should look into hrtime.bugint()
Anothe thing here that you get nanoseconds and then you've added additional check and division to get milliseconds and after all you are rounding value. Why? Will it be more easy to use Data.now() and calculate difference between it? Simple it could be achieved in 2 rows const start = Date.now() and commandExecution.executionTime = Date.now() - statrt. That is it.
…ub.com/RedisInsight/RedisInsight into feature/RI-3751_command_execution_time
…ub.com/RedisInsight/RedisInsight into feature/RI-3751_command_execution_time
rsergeenko
previously approved these changes
Nov 4, 2022
ArtemHoruzhenko
previously approved these changes
Nov 7, 2022
| .toEqual(mockCommandExecutionToRun); | ||
| const result = await service.createCommandExecution(mockClientOptions, mockCreateCommandExecutionDto); | ||
| // can't predict execution time | ||
| expect(result).toMatchObject(mockCommandExecutionToRun); |
There was a problem hiding this comment.
toMatchObject nice! didn't know this useful feature :)
…ub.com/RedisInsight/RedisInsight into feature/RI-3751_command_execution_time
…ion-time E2e/feature/ri 3751 execution time
ArtemHoruzhenko
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.