RI-3892 - Tree View Improvements #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
vlad-dargel
suggested changes
Dec 8, 2022
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e copy.ts
Outdated
Show resolved
Hide resolved
| Selector(`[data-testid="node-item_${folders[0]}:${folders[1]}:keys:keys:"]`).visible) | ||
| .ok("Folder is not selected"); | ||
|
|
||
| }); |
There was a problem hiding this comment.
Don't see these tests:
- "The folder without any patterns selected and the list of keys is displayed when there is a folder without any patterns"
- The folder without any namespaces is selected (if exists) when folder does not exist after search/filter
- The first folder with namespaces is expanded and selected when folder and folder without any namespaces does not exist after search/filter
(it is when one folder is opened and you search for key from other folder - other folder should be opened after such search) - The previously selected folder is preselected when key does not exist after keys refresh (you need to select one folder, then delete any key from this folder by CLI and click refresh - verify that the same folder still selected)
…b.com/RedisInsight/RedisInsight into e2e/feature/RI-3892_treeViewImprovements
nmammadli
changed the base branch from
main
to
feature/RI-3355_Tree_view_improvments
nmammadli
changed the base branch from
feature/RI-3355_Tree_view_improvments
to
main
nmammadli
changed the base branch from
main
to
feature/RI-3355_Tree_view_improvments
vlad-dargel
changed the base branch from
feature/RI-3355_Tree_view_improvments
to
main
vlad-dargel
changed the base branch from
main
to
feature/RI-3355_Tree_view_improvments
…/RI-3892_treeViewImprovements
…thub.com/RedisInsight/RedisInsight into e2e/feature/RI-3892_treeViewImprovements
vlad-dargel
reviewed
Dec 13, 2022
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e.ts
Outdated
Show resolved
Hide resolved
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e.ts
Outdated
Show resolved
Hide resolved
vlad-dargel
reviewed
Dec 13, 2022
tests/e2e/tests/critical-path/tree-view/tree-view-improvements.e2e.ts
Outdated
Show resolved
Hide resolved
nmammadli
force-pushed
the
e2e/feature/RI-3892_treeViewImprovements
branch
from
b496361 to
dbe0380
Compare
vlad-dargel
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.