[E2E] Workbench tests are added #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofersteinberg
suggested changes
Dec 26, 2021
| //Go back to Workbench page | ||
| await t.click(myRedisDatabasePage.workbenchButton); | ||
| //Check that scroll position is saved | ||
| await t.expect(workbenchPage.scrolledEnablementArea.scrollTop).eql(scrollPosition, 'Scroll position is correct'); |
There was a problem hiding this comment.
Regarding the error message, the more correct is The scroll position status
| //Select Command Palette option | ||
| await t.click(workbenchPage.monacoContextMenu.find(workbenchPage.cssMonacoCommandPaletteLine)); | ||
| //Print "Run Commands" shortcut | ||
| await t.typeText(workbenchPage.monacoShortcutInput, 'Run Commands'); |
There was a problem hiding this comment.
I recommend using with { replace: true, paste: true } on typeText
There was a problem hiding this comment.
Did not add replace and paste options because monaco context menu doesn't work with them and test fails. Need "typeahead" behavior in this test
| await t.click(workbenchPage.monacoSuggestionOption); | ||
| //Check the result with sent command | ||
| const commandTextInResult = await workbenchPage.queryCardCommand.withExactText(command); | ||
| await t.expect(commandTextInResult.exists).ok('Result of sent command exists'); |
There was a problem hiding this comment.
More accurate error message: The result of sent command
ofersteinberg
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are added: