-
Notifications
You must be signed in to change notification settings - Fork 404
[E2E] Monitor tests are added #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
//Check for "info" command that is sent every 5 seconds | ||
await t.wait(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE automatically sends "info" command every 5 seconds. Starting monitor I am waiting 5 seconds just to get this command logged inside of monitor (just to make sure that monitor is started).
I had "checkCommandInMonitorResults" function that checked if a specified command appeared in monitor (without timeouts) but for the one "info" command used "t.wait".
Fixed according to your comment (now { timeout: 5000 } is set for any command in the function "checkCommandInMonitorResults").
await t.click(this.startMonitorButton); | ||
//Check for "info" command that is sent every 5 seconds | ||
await t.wait(5000); | ||
// await this.checkCommandInMonitorResults('info'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
//Check that command from Workbench is displayed in monitor | ||
await monitorPage.checkCommandInMonitorResults(workbench_command); | ||
//Wait for info request | ||
await t.wait(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this, and not { timeout: 5000 }
within the function when you assert it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -0,0 +1,83 @@ | |||
import { addNewStandaloneDatabase } from '../../../helpers/database'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you don't have import testcafe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that understood your question. Could you please rephrase?
…/RedisInsight into feature/e2e-monitor
# Conflicts: # redisinsight/ui/src/components/monitor/Monitor/Monitor.tsx
The following tests are added:
-Verify that user can work with Monitor
-Verify that when user closes the Monitor by clicking on "Close Monitor" button Monitor stopped
-Verify that user can see the list of all commands from all clients ran for this Redis database in the list of results in Monitor
-Verify that when user reopens Monitor history is not displayed