Skip to content

Conversation

elenaNaboko
Copy link
Contributor

The following tests are added:
-Verify that user can work with Monitor
-Verify that when user closes the Monitor by clicking on "Close Monitor" button Monitor stopped
-Verify that user can see the list of all commands from all clients ran for this Redis database in the list of results in Monitor
-Verify that when user reopens Monitor history is not displayed

Comment on lines 64 to 65
//Check for "info" command that is sent every 5 seconds
await t.wait(5000);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE automatically sends "info" command every 5 seconds. Starting monitor I am waiting 5 seconds just to get this command logged inside of monitor (just to make sure that monitor is started).
I had "checkCommandInMonitorResults" function that checked if a specified command appeared in monitor (without timeouts) but for the one "info" command used "t.wait".
Fixed according to your comment (now { timeout: 5000 } is set for any command in the function "checkCommandInMonitorResults").

await t.click(this.startMonitorButton);
//Check for "info" command that is sent every 5 seconds
await t.wait(5000);
// await this.checkCommandInMonitorResults('info');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

//Check that command from Workbench is displayed in monitor
await monitorPage.checkCommandInMonitorResults(workbench_command);
//Wait for info request
await t.wait(5000);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this, and not { timeout: 5000 } within the function when you assert it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -0,0 +1,83 @@
import { addNewStandaloneDatabase } from '../../../helpers/database';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you don't have import testcafe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that understood your question. Could you please rephrase?

@elenaNaboko elenaNaboko merged commit 4504a83 into feature/RI-1227_monitor Feb 1, 2022
@ArtemHoruzhenko ArtemHoruzhenko deleted the feature/e2e-monitor branch February 25, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants