#RI-4567 - Refactoring main.dev.js #2182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested changes
Jun 12, 2023
There was a problem hiding this comment.
In general it is not clear for me why we decide to you such files structure.
What is difference between lib, services, handlers, etc. I prefer to use domains like auto-update folder will have everything needed for auto-updates, etc
Also we must think about using statefull cached modules vs DI. each approach has own pros and cons
Base automatically changed from
build/feature/RI-4265_Enchance_opening_window_Electron
to
feature/RI-2850_Electron_improvements
June 12, 2023 12:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#RI-4567 - Refactoring main.dev.js