#RI-4265 - Enhance the window opening in Electron #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested changes
Jun 12, 2023
| @@ -31,9 +30,6 @@ export default merge(mainProdConfig, { | |||
| APP_VERSION: version, | |||
| AWS_BUCKET_NAME: 'AWS_BUCKET_NAME' in process.env ? process.env.AWS_BUCKET_NAME : '', | |||
| SEGMENT_WRITE_KEY: 'SEGMENT_WRITE_KEY' in process.env ? process.env.SEGMENT_WRITE_KEY : 'SOURCE_WRITE_KEY', | |||
| CONNECTIONS_TIMEOUT_DEFAULT: 'CONNECTIONS_TIMEOUT_DEFAULT' in process.env | |||
There was a problem hiding this comment.
Why did you remove this env?
|
|
||
| contextBridge.exposeInMainWorld('electron', electronHandler); | ||
|
|
||
| contextBridge.exposeInMainWorld('ENV_VARS', { |
There was a problem hiding this comment.
I don't like to export env variables. Let's have electron.config object with everything needed. What do you think?
| import path from 'path'; | ||
|
|
||
| export function resolveHtmlPath(htmlFileName: string) { | ||
| if (process.env.NODE_ENV === 'development') { |
There was a problem hiding this comment.
I really do not understand why somewhere we are using envVars somewhere process.env and what was the goal
ArtemHoruzhenko
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Approve with agreement that not resolved comments will be addressed in another PR #2182
egor-zalenski
changed the base branch from
main
to
feature/RI-2850_Electron_improvements
egor-zalenski
deleted the
build/feature/RI-4265_Enchance_opening_window_Electron
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#RI-4265 - Enhance the window opening in Electron