#RI-2450 - add tutorials provider #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested changes
Mar 15, 2022
redisinsight/api/src/modules/shared/services/instances-business/auto-discovery.service.ts
Show resolved
Hide resolved
…nto feature/RI-2450_update_static
ArtemHoruzhenko
requested changes
Mar 18, 2022
| "build:defaults:content": "ts-node ./scripts/default-content.ts", | ||
| "build:defaults": "yarn build:defaults:enablement-area && yarn build:defaults:commands yarn build:defaults:content", | ||
| "build:defaults": "yarn build:defaults:guides && yarn build:defaults:commands && yarn build:defaults:content", | ||
| "prebuild": "rimraf dist", |
There was a problem hiding this comment.
Did you test it locally? I assume that default tutorials will not work because I don't see build:defaults:tutorials here
There was a problem hiding this comment.
I didn't include the tutorials because there are no files in the repository, so the script will fail with an error
There was a problem hiding this comment.
Please, do not hurry up build:defaults:tutorialss
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
No newline at the end of file
| }); | ||
| }); | ||
| }); | ||
| }); |
| * Exract file in folder | ||
| */ | ||
| export const updateFile = async (path: string, fileName: string, data: any): Promise<void> => { | ||
|
|
There was a problem hiding this comment.
Do you use linter? It should highlite extra line here
ArtemHoruzhenko
requested changes
Mar 18, 2022
| "build:defaults:content": "ts-node ./scripts/default-content.ts", | ||
| "build:defaults": "yarn build:defaults:enablement-area && yarn build:defaults:commands yarn build:defaults:content", | ||
| "build:defaults": "yarn build:defaults:guides && yarn build:defaults:commands && yarn build:defaults:content", | ||
| "prebuild": "rimraf dist", |
There was a problem hiding this comment.
Please, do not hurry up build:defaults:tutorialss
ArtemHoruzhenko
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.