Skip to content

Be/feature/ri 5876 fix start electron dev mode #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Nov 28, 2024
Merged

Be/feature/ri 5876 fix start electron dev mode #4021

merged 65 commits into from
Nov 28, 2024

Conversation

KIvanow
Copy link
Contributor

@KIvanow KIvanow commented Oct 28, 2024

A continuation of - #4017

Kristiyan Ivanov added 20 commits October 16, 2024 11:21
Change the wording on the native browser authentication page
e27cef8
RI-5876-Fix start electron dev mode
8b6c1b0 
Initial working POC - to be cleaned
RI-5876 Fix start electron dev mode - cleanup
eedcbf0
RI-5876 Fix Electron in dev mode -> fix for window validation in dev …
31b7f1d 
…(POC)
RI-5876 Fix start electron dev mode - clean up and hardcoded values
4e0431d
RI-5876 fix start electron dev mode - fixed auth flow for dev with tcp
e8b543b
RI-5876 Fix start electron dev mode - cleanup
ca5afa5
RI-5876 fix start electron dev - cleanup
58fc233
RI-5876 fix electron dev mode - further cleanup and removal of
e9f3ee8
RI-5876
7c324cc
RI-5876 Fix start electron dev mode
331b2d1
RI-5876 fix electron dev mode - removed hardcoded if statement
da77e73
RI-5876 fix electron dev mode - removed unused dependency
ca4fc09
Merge branch 'RI-5876-Fix-start-electron-dev-mode' of https://github.…
2e63fdf 
…com/RedisInsight/RedisInsight into RI-5876-Fix-start-electron-dev-mode
RI-5876 cleanup
0d20c20
RI-5876 cleanup
b030c90
RI-5876 cleanup
531dda9
RI-5876 cleanup
3b22245
RI-5876 - cleaned up console.logs
4b790fe
RI-5876 fixed eslint errors
c9c9830
KIvanow and others added 2 commits October 28, 2024 17:38
@KIvanow
RI-6876 fixed api test (#4022)
dfdfb09
@KIvanow @rsergeenko
@vlad-dargel @ArtemHoruzhenko @mariasergeenko @GnaneshKunal @kchepikava @ViktarStarastsenka @egor-zalenski @drivebyer
Ri 5876 fix start electron dev mode (#4023)
9e3beff 
* refactoring

* #RI-6061 - fix overflow

* #RI-6062 - add initial commands json

* changes from main

* #RI-6026 - support apply functions, filter expressions, reducer functions

* #RI-6026 - add tests, fix tests

* #RI-6026 - remove console.log

* #RI-6027 - add completion types for query fields

* #RI-6027 - remove commented code

* add profile and explain tests

* fixes

* add waiter because of slow work of suggestions

* add env variable for local

* add env

* add method for selecting query

* #RI-6091 - fix highlighting
#RI-6093 - fix expression suggestions

* init implementation

* #RI-6079 - update colors

* test for APPLY, FILTER and REDUCE

* fix tests + small rework

* fix tests

* fix tests

* test for suggestions for fields

* add migrations

* #RI-5992 - update search and query history

* #RI-6079 - update colors
#RI-6099 - highlight fields

* #RI-6108 - fix clear results
#RI-6109 - fix history
#RI-6110 - fix profile/explain

* add tests for search history

* remove unused meta

* #RI-6086 - fix number of args next to count
#RI-6088 - fix multiple arguments

* revert theme

* Dynamically show multiple byte formats

* #RI-6100 - merge colors

* #RI-6111 - fix suggestions

* fix vector

* #RI-6119 - move browser pages from tabs to menu

* #RI-6119 - add tests, fix test

* Add support for 1000 base which is used for network metrics

* Remove console log

* refactoring

* fix some issues

* #RI-6085 - fix sending query

* #RI-6089 - add support ft commands

* #RI-6089 - fix suggestions

* #RI-6137 - update quotes and colors

* #RI-6135 - cover no indexes case
* fix last page context

* #RI-6135 - update link

* #RI-6135 - fix tests

* add test when there is no index

* RI-6089_support-ft-commands

* RI-6141 update rdi last connection on each connect

* #RI-6151 - initial implementation of search suggestions in the workbench

* RI-6191 fixed text

* RI-6153 renamed and added tooltips to dry-run panel tabs

* #RI-6151 - search suggestions in the workbench, refactoring

* #RI-6151 - fix pr comments

* Fixed tests flagged by Maria

* remove separate tab

* RI-6141 await rdiClient before updating

* Update README.md

* fix part of tests

* temp fix

* recommendation fix

* fix for tutorials

* fix for tutorials#2

* #RI-6173, #RI-6177, #RI-6178, #RI-6182, #RI-6183 - fix bugs

* Update README.md

* #RI-6158 - Migrate build workflows from CircleCI to Github Actions

* fix monitor typo

* #RI-6158 - Migrate build workflows from CircleCI to Github Actions

* #RI-6158 - Migrate build workflows from CircleCI to Github Actions

* #RI-6158 - Migrate build workflows from CircleCI to Github Actions

* #RI-6158 - Migrate build workflows from CircleCI to Github Actions

* update response

* #RI-6203 - fix suggestions

* unskip

* #RI-6158 - Turn off auto run Unit tests

* #RI-6158 - Turn off auto run Unit tests

* #RI-6158 - Add $ENV to docker build

* add fix for headers

* comment check

* #RI-6132 - update sanitizer

* Delete .github/README.md

* remove brocken commands

* #RI-6217 - fix suggestions
#RI-6218 - fix cypher editor
* small refactoring

* update existing tests

* Fix zero byte case

* update root dependencies

* update

* remove opening by keyboard

* move to newest class-transformer and class-validator

* #RI-6221 - fix arguments in details

* update jest

* update root dependencies

* fix tests

* fix unit tests

* upgrade nest packages

* the rest of nestjs libraries

* fix the rest of the modules + electron

* setup codeql to ignore test files/folders

* exclude api/test folder from codeql analysis

* upgrade all the packages

* upgrade all the packages

* #RI-6222 - fix auto-suggest at first column
* start refactoring

* bump ip

* fix pr comments

* bump ts-node

* fix minifying

* ts fixes

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* test

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6228 - fix load all, composite args

* add ui tests

* fix

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* #RRI-6172 - remove search page

* fix2

* rollback class-transform to 0.3.x (0.3.1)

* upgrade nestjs + okta packages. cleanup resolutions

* degrade nest-form-data

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* test

* #RI-6213 - Migrate release workflows from CircleCI to Github Actions

* RI-6220 removed rdi pipeline template

* upgrade webpack

* upgrade msw/cookie

* RI-6225 social button fix

* e2e/feature/RI-6220_remove-rdi-pipeline-template

* RI-6240 fix tooltip style

* #RI-6234 - fix error showing when no indexes

* RI-6171 User cannot create vector index using form

* e2e/bugfix/tsconfig-fix

* RI-6171 User cannot create vector index using form - updated tests

* Simplified check based on suggestion from Roman

* e2e/bugfix/fir-delete-all-keys-redis

* #RI-6208 - improve switch between redis and search syntax, add command scope
#RI-6211 - fix highlighting when there are several the same args

* #RI-6226 - add sorting for list of commands
#RI-6244 - fix finding of command

* e2e/feature/RI-6226_change_sorting_for_ft

* fix ts issue

* fix ITests

* fix detail token

* fix ITests

* Fix Dockerfile

* RI-6876 fixed api test

---------

Co-authored-by: Roman Sergeenko <roman.sergeenko@softeq.com>
Co-authored-by: vlad-dargel <u.darhel@aisnovations.com>
Co-authored-by: Vlad <vladislav.darhel@softeq.com>
Co-authored-by: ArtemHoruzhenko <artem.horuzhenko@redis.com>
Co-authored-by: mariasergeenko <maria.sergeenko@softeq.com>
Co-authored-by: Gnanesh <gnaneshkunal@outlook.com>
Co-authored-by: kchepikava <krystsina.chepikava@softeq.com>
Co-authored-by: ViktarStarastsenka <99594890+ViktarStarastsenka@users.noreply.github.com>
Co-authored-by: zalenskiSofteq <egor.zalenski@softeq.com>
Co-authored-by: yangw <yang.wu@daocloud.io>
@egor-zalenski
Copy link
Contributor

egor-zalenski commented Oct 30, 2024 •
edited
Loading

Run command yarn dev:electron on Macos I have a white screen, what should I do?
image

en error
image

egor-zalenski
egor-zalenski reviewed Nov 7, 2024
View reviewed changes
@KIvanow KIvanow requested a review from egor-zalenski November 8, 2024 09:03
egor-zalenski
egor-zalenski reviewed Nov 8, 2024
View reviewed changes
ArtemHoruzhenko
ArtemHoruzhenko reviewed Nov 11, 2024
View reviewed changes
redisinsight/desktop/src/lib/cloud/cloud-oauth.handlers.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to not forget to discuss this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArtemHoruzhenko I believe I went through all of your comments. What did we discuss about this one though? I think it's the only thing I can't remember

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly we agreed that we must implement some kind of strategy pattern for transport layer. So you will be able to switch via env or config between ipc and tcp for intra renderer and main processes communication

ArtemHoruzhenko
ArtemHoruzhenko reviewed Nov 20, 2024
View reviewed changes
redisinsight/desktop/src/lib/cloud/cloud-oauth.handlers.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly we agreed that we must implement some kind of strategy pattern for transport layer. So you will be able to switch via env or config between ipc and tcp for intra renderer and main processes communication

redisinsight/api/yarn.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must be very careful here.
I would suggest you during merging main->thisbranch to accept all chnages from main and install everything you need again on top of latest changes from main. After that we can merge feature back to main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the process I usually follow after every conflict resolution with the main.

ArtemHoruzhenko
ArtemHoruzhenko previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Merge branch 'main' of https://github.com/RedisInsight/RedisInsight i…
d145e49 
…nto be/feature/RI-5876-Fix-start-electron-dev-mode
ArtemHoruzhenko
ArtemHoruzhenko approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KIvanow KIvanow merged commit a968777 into main Nov 28, 2024
28 checks passed
@KIvanow KIvanow deleted the be/feature/RI-5876-Fix-start-electron-dev-mode branch November 28, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtemHoruzhenko ArtemHoruzhenko ArtemHoruzhenko approved these changes

@ViktarStarastsenka ViktarStarastsenka Awaiting requested review from ViktarStarastsenka

@egor-zalenski egor-zalenski Awaiting requested review from egor-zalenski

Assignees

@KIvanow KIvanow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KIvanow @egor-zalenski @ArtemHoruzhenko