Skip to content
Discussion options

You must be logged in to vote

Hey @nei10u
c.close() is blocking and the reason it was offloaded to ForkJoinPool.commonPool() after issue #453 is because the callback would have run on Nettys eventloop otherwise.
However, later closeAsync() was introduced, which is indeed non-blocking. If we use it i think we can safely switch to whenComplete.
I think there are a few other occurrences of delegation to ForkJoinPool.commonPool() in RedisHandshake path and MultiDB.
You are welcome to open an issue if you like.

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by a-TODO-rov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants