Ineffective creatiion of arguments for mset, msetnx, hmset

[Suor]

diff --git a/redis/client.py b/redis/client.py
index 41a9660..bbec57a 100644
--- a/redis/client.py
+++ b/redis/client.py
@@ -578,18 +578,14 @@ class Redis(threading.local):

    def mset(self, mapping):
        "Sets each key in the ``mapping`` dict to its corresponding value"
-        items = []
-        [items.extend(pair) for pair in mapping.iteritems()]
-        return self.execute_command('MSET', *items)
+        return self.execute_command('MSET', *mapping.items())

    def msetnx(self, mapping):
        """
        Sets each key in the ``mapping`` dict to its corresponding value if
        none of the keys are already set
        """
-        items = []
-        [items.extend(pair) for pair in mapping.iteritems()]
-        return self.execute_command('MSETNX', *items)
+        return self.execute_command('MSETNX', *mapping.items())

    def move(self, name, db):
        "Moves the key ``name`` to a different Redis database ``db``"
@@ -1132,9 +1128,7 @@ class Redis(threading.local):
        Sets each key in the ``mapping`` dict to its corresponding value
        in the hash ``name``
        """
-        items = []
-        [items.extend(pair) for pair in mapping.iteritems()]
-        return self.execute_command('HMSET', name, *items)
+        return self.execute_command('HMSET', name, *mapping.items())

    def hmget(self, name, keys):
        "Returns a list of values ordered identically to ``keys``"

[andymccurdy]

These only work if the mapping object only has a single key/value pair. Multiple key/value pairs will provide *args that look like:

((key1, value1), (key2, value2), ...)

[Suor]

You are right, sorry.
Still
for pair in mapping.iteritems(): items.extend(pair)
is faster then
[items.extend(pair) for pair in mapping.iteritems()]

Python 2.6.5, Linux 2.6.32, x86_64

[andymccurdy]

Fair enough. Commited in 16c0eff