Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos. #1496

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Fix some typos. #1496

merged 1 commit into from
Aug 8, 2021

Conversation

enjoy-binbin
Copy link
Contributor

Hi @andymccurdy I found some typos and i try to fix thoes.
Please take a look for me when you have time. Thanks

@chayim chayim self-requested a review July 15, 2021 07:18
@chayim
Copy link
Contributor

chayim commented Jul 15, 2021

@enjoy-binbin Since you're making language changes, what do you think about running aspell against the docs and codebase in general? If you have a Linux, aspell check FILENAME helps.

@enjoy-binbin
Copy link
Contributor Author

@chayim Hi
Those errors are what I found when i looking at the pipeline implementation.
I think that would be great if we can check the spell error.

Actually we can create a CI action to check, like https://github.com/redis/redis/blob/unstable/.github/workflows/spell-check.yml

@chayim chayim merged commit 8c4fc80 into redis:master Aug 8, 2021
@enjoy-binbin enjoy-binbin deleted the fix_typos branch August 8, 2021 09:29
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
Fix some typos. (redis/redis-py#1496)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants