New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getex #1515

Merged

chayim merged 3 commits into redis:master from AvitalFineRedis:GETEX

Jul 22, 2021

Contributor

AvitalFineRedis commented Jul 21, 2021 •

edited

Pull Request check-list

Please make sure to review and check all of these items:

Does $ tox pass with this change (including linting)?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add support to GETEX


          getex

9b33349

Contributor Author

AvitalFineRedis commented Jul 21, 2021


          flake8 fix

1eebecd

chayim reviewed

View reviewed changes

redis/client.py Outdated Show resolved Hide resolved

chayim reviewed

View reviewed changes

redis/client.py Show resolved Hide resolved

chayim reviewed

View reviewed changes

redis/client.py Show resolved Hide resolved

chayim reviewed

View reviewed changes

redis/client.py Outdated Show resolved Hide resolved

chayim reviewed

View reviewed changes

tests/test_commands.py Outdated Show resolved Hide resolved

chayim reviewed

View reviewed changes

tests/test_commands.py Show resolved Hide resolved

chayim reviewed

View reviewed changes

redis/client.py Show resolved Hide resolved

chayim reviewed

View reviewed changes

redis/client.py Show resolved Hide resolved


          comments

2dc3a8a

Contributor Author

AvitalFineRedis commented Jul 22, 2021

Contributor

chayim commented Jul 22, 2021

Thanks for your contirbution!

chayim merged commit 3c244af into redis:master

chayim pushed a commit to chayim/redis-py that referenced this pull request


          getex (redis#1515)

98d0c30

* getex

* flake8 fix

* comments

Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request


          Add redis/redis-py@3c244af

a389184

getex (redis/redis-py#1515)

* Removed small doc saying all time parameters can be datetime.timedelta. This is not needed with typing and can also be confusing with PXAT and EXAT

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment