Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential test case typo in test_zadd_gt_lt #1585

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

There may be a typo in the tests where an invalid keyword argument is passed

@Andrew-Chen-Wang
Copy link
Contributor Author

I'm also curious why the lt and gt args have integers in the test cases? I thought they were simple booleans?

@chayim
Copy link
Contributor

chayim commented Oct 5, 2021

Thanks for catching this @Andrew-Chen-Wang ! You're absolutely right.

@chayim chayim merged commit 677476d into redis:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants