Skip to content

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim
Copy link
Contributor

chayim commented Oct 14, 2021

@Andrew-Chen-Wang Thanks for the contribution. I appreciate that it's easier to read - and that I played with exceptions a bit more in depth as a result of all these. Much appreciated, keep 'em coming!

I'll merge this, and others shortly.

@chayim chayim merged commit 65c4334 into redis:master Oct 14, 2021
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-11 branch October 14, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants