Skip to content

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Dec 2, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #1770 (f183667) into master (d4a9825) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   92.00%   91.92%   -0.09%     
==========================================
  Files          74       74              
  Lines       15617    15616       -1     
==========================================
- Hits        14369    14355      -14     
- Misses       1248     1261      +13     
Impacted Files Coverage Δ
tests/test_connection_pool.py 94.54% <ø> (ø)
redis/retry.py 95.23% <0.00%> (-4.77%) ⬇️
tests/test_graph_utils/test_edge.py 94.59% <0.00%> (-2.71%) ⬇️
tests/test_graph.py 88.38% <0.00%> (-1.54%) ⬇️
tests/test_graph_utils/test_path.py 97.01% <0.00%> (-1.50%) ⬇️
tests/test_lock.py 99.47% <0.00%> (-0.53%) ⬇️
tests/test_json.py 99.80% <0.00%> (-0.20%) ⬇️
tests/test_cluster.py 97.24% <0.00%> (-0.14%) ⬇️
tests/test_commands.py 93.36% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a9825...f183667. Read the comment docs.

@chayim chayim merged commit 8af9a3f into master Dec 2, 2021
@chayim chayim deleted the ck-fixblack branch December 2, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants