Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for list commands #1917

Merged
merged 6 commits into from
Feb 3, 2022
Merged

Add type hints for list commands #1917

merged 6 commits into from
Feb 3, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 30, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the feature New feature label Jan 30, 2022
@dvora-h dvora-h requested a review from chayim January 30, 2022 15:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #1917 (b822fda) into master (0d26117) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
- Coverage   93.02%   92.99%   -0.03%     
==========================================
  Files          76       76              
  Lines       16537    16537              
==========================================
- Hits        15383    15379       -4     
- Misses       1154     1158       +4     
Impacted Files Coverage Δ
redis/commands/core.py 90.15% <100.00%> (ø)
tests/test_cluster.py 98.16% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d26117...b822fda. Read the comment docs.

redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the old defaults (eg timeout=0) continue to work. Type hints if done correctly should work without unit test changes.

Our unit tests should just keep working. IMHO take out the unit test changes, and see what doesn't pass. This influences the type hint changes.

@dvora-h dvora-h requested a review from chayim January 31, 2022 10:52
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - let's validate it works with CI once I fix redismod docker

@dvora-h dvora-h merged commit a5e5996 into redis:master Feb 3, 2022
@dvora-h dvora-h deleted the list-t-h branch February 3, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants