Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.6 back to hash verify CI #2008

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add Python 3.6 back to hash verify CI #2008

merged 1 commit into from
Feb 23, 2022

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Is the changes added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

chayim
chayim reviewed Feb 23, 2022
View reviewed changes
.github/workflows/integration.yaml
@@ -80,7 +80,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', 'pypy-3.7']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow.. oops. Thanks @Andrew-Chen-Wang here I thought I got them all. 🦸

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Feb 23, 2022
@chayim chayim merged commit 6df1ba3 into redis:master Feb 23, 2022
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-5 branch February 23, 2022 20:50
dvora-h pushed a commit to jakebarnwell/redis-py that referenced this pull request Mar 1, 2022
@Andrew-Chen-Wang @dvora-h
Add Python 3.6 back to hash verify CI (redis#2008)
6979ea3
dvora-h added a commit that referenced this pull request Mar 1, 2022
@jakebarnwell @chayim
@Andrew-Chen-Wang @dvora-h
Implement locks for RedisCluster (#2013)
6149004 
* Add support for .lock() for RedisCluster

* Update changelog with lua scripting and lock() changes

* Also update asyncio client .lock() doc

* Add Python 3.6 back to hash verify CI (#2008)

* Renaming chore as maintenance (#2015)

* Add AsyncFunctionCommands (#2009)

* Also update asyncio client .lock() doc

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Andrew Chen Wang <60190294+Andrew-Chen-Wang@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Andrew-Chen-Wang @chayim