Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make typing_extensions conditional to Python < 3.8 #2062

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 24, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

All the typing features used by redis-py are available in Python 3.8+,
so typing_extensions is not used at all in newer versions of Python.
Adjust the dependencies accordingly.

All the typing features used by redis-py are available in Python 3.8+,
so typing_extensions is not used at all in newer versions of Python.
Adjust the dependencies accordingly.
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #2062 (d095608) into master (ef4caf5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2062   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         100      100           
  Lines       21319    21319           
=======================================
  Hits        19443    19443           
  Misses       1876     1876           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4caf5...d095608. Read the comment docs.

@mgorny
Copy link
Contributor Author

mgorny commented Mar 24, 2022

I'm getting some test failures from tox but they seem irrelevant to the changes at hand.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Mar 29, 2022
@chayim
Copy link
Contributor

chayim commented Mar 29, 2022

Thanks @mgorny for this!

@dvora-h dvora-h merged commit 9cfcaa4 into redis:master Mar 31, 2022
@mgorny
Copy link
Contributor Author

mgorny commented Mar 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants