Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify bit type in setbit/getbit documentation #2078

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

dsoprea
Copy link
Contributor

@dsoprea dsoprea commented Apr 1, 2022

Calling it 'boolean' is misleading in the context of Python.

Pull Request check-list

Please make sure to review and check all of these items:

  • [N] Does $ tox pass with this change (including linting)? Missing support for all Python versions on local
  • [Y] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [Y] Is the new or changed code fully tested?
  • [Y] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [NA] Is there an example added to the examples folder (if applicable)?
  • [N] Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Clarified certain types cited in the setbit/getbit comments->documentation.

Calling it 'boolean' is misleading in the context of Python.
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Apr 3, 2022
@chayim chayim changed the title commands/core.py: Clarify bit type Clarify bit type in setbit/getbit documentation Apr 3, 2022
@dvora-h dvora-h merged commit 7b7c6c8 into redis:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants