Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asynic/client.py's import #2079

Merged
merged 2 commits into from
Apr 4, 2022
Merged

fix asynic/client.py's import #2079

merged 2 commits into from
Apr 4, 2022

Conversation

wwqgtxx
Copy link
Contributor

@wwqgtxx wwqgtxx commented Apr 3, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

redis.asyncio.Redis's Lock and Retry should be from redis.asyncio

Lock and Retry should be from redis.asyncio
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #2079 (eb656ca) into master (876cafc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         100      100           
  Lines       21361    21361           
=======================================
  Hits        19489    19489           
  Misses       1872     1872           
Impacted Files Coverage Δ
redis/asyncio/client.py 90.63% <100.00%> (ø)
tests/test_cluster.py 97.42% <0.00%> (-0.13%) ⬇️
redis/asyncio/connection.py 82.75% <0.00%> (ø)
tests/conftest.py 87.20% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cafc...eb656ca. Read the comment docs.

Copy link
Collaborator

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwqgtxx Nice catch! Thanks for this!

@dvora-h dvora-h added the bug Bug label Apr 4, 2022
@dvora-h dvora-h merged commit e6968f8 into redis:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants