Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Redis 7 #2182

Merged
merged 4 commits into from
May 31, 2022
Merged

Fix tests for Redis 7 #2182

merged 4 commits into from
May 31, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented May 16, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

#2153

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label May 16, 2022
@dvora-h dvora-h requested a review from chayim May 16, 2022 09:12
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #2182 (c36a4f2) into master (c54dfa4) will decrease coverage by 0.02%.
The diff coverage is 34.04%.

@@            Coverage Diff             @@
##           master    #2182      +/-   ##
==========================================
- Coverage   91.88%   91.85%   -0.03%     
==========================================
  Files         108      108              
  Lines       27389    27387       -2     
==========================================
- Hits        25166    25157       -9     
- Misses       2223     2230       +7     
Impacted Files Coverage Δ
redis/cluster.py 90.34% <ø> (ø)
tests/test_command_parser.py 93.87% <ø> (-0.47%) ⬇️
tests/test_scripting.py 93.67% <0.00%> (ø)
tests/test_commands.py 89.93% <7.14%> (+0.12%) ⬆️
tests/test_function.py 29.06% <9.09%> (+1.48%) ⬆️
tests/test_cluster.py 97.03% <25.00%> (+0.24%) ⬆️
tests/test_asyncio/test_commands.py 98.06% <78.57%> (-1.54%) ⬇️
redis/commands/parser.py 63.33% <100.00%> (-4.45%) ⬇️
tests/test_encoding.py 98.75% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54dfa4...c36a4f2. Read the comment docs.

@dvora-h dvora-h merged commit 04bc576 into redis:master May 31, 2022
@dvora-h dvora-h deleted the redis7-tests branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants