Add support for TIMESERIES 1.8 #2296

dvora-h · 2022-07-21T11:30:01Z

Pull Request check-list

Please make sure to review and check all of these items:

Does $ tox pass with this change (including linting)?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?
Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2282 closes #2283 closes #2284 closes #2285 closes #2286 closes #2287 closes #2064

codecov-commenter · 2022-07-21T11:53:50Z

Codecov Report

Merging #2296 (32b33ed) into master (e6cd4fd) will increase coverage by 0.07%.
The diff coverage is 99.56%.

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
+ Coverage   91.85%   91.92%   +0.07%     
==========================================
  Files         108      109       +1     
  Lines       27783    28001     +218     
==========================================
+ Hits        25521    25741     +220     
+ Misses       2262     2260       -2

Impacted Files	Coverage Δ
redis/commands/timeseries/commands.py	`99.00% <98.24%> (-0.50%)`	⬇️
redis/commands/timeseries/info.py	`91.42% <100.00%> (ø)`
tests/test_timeseries.py	`100.00% <100.00%> (ø)`
...s/test_asyncio/test_sentinel_managed_connection.py	`100.00% <0.00%> (ø)`
tests/test_cluster.py	`97.08% <0.00%> (+0.11%)`	⬆️
redis/asyncio/connection.py	`84.21% <0.00%> (+0.14%)`	⬆️
redis/asyncio/sentinel.py	`87.57% <0.00%> (+0.15%)`	⬆️
tests/test_asyncio/test_connection.py	`98.52% <0.00%> (+1.16%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cd4fd...32b33ed. Read the comment docs.

chayim · 2022-07-21T12:20:07Z

redis/commands/timeseries/commands.py

@@ -31,34 +31,25 @@ def create(self, key, **kwargs):
        key:
            time-series key
        retention_msecs:
-            Maximum age for samples compared to last event time (in milliseconds).
+            Maximum age for samples compared to highest reported timestamp (in milliseconds).


chayim · 2022-07-21T12:20:38Z

redis/commands/timeseries/commands.py

        """  # noqa
        return self.execute_command(DEL_CMD, key, from_time, to_time)

-    def createrule(self, source_key, dest_key, aggregation_type, bucket_size_msec):
+    def createrule(


redis/commands/timeseries/commands.py

tests/test_timeseries.py

chayim · 2022-07-21T12:22:46Z

tests/test_timeseries.py

+    timeseries.add("t1", 73, 5)
+    timeseries.add("t1", 75, 3)
+    assert [(70, 5.0), (50, 3.0), (10, 4.0)] == timeseries.revrange(
+        "t1", 0, 100, align=0, aggregation_type="max", bucket_size_msec=10


What do you think of making accessors for aggregation types?

redis/commands/timeseries/info.py

* Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters

* Add support for async graph * linters * fix docstring * Use retry mechanism in async version of Connection objects (#2271) * fix is_connected (#2278) * fix: workaround asyncio bug on connection reset by peer (#2259) Fixes #2237 * Fix crash: key expire while search (#2270) * fix expire while search * sleep * docs: Fix a few typos (#2274) * docs: Fix a few typos There are small typos in: - redis/cluster.py - redis/commands/core.py - redis/ocsp.py - tests/test_cluster.py Fixes: - Should read `validity` rather than `valididy`. - Should read `reinitialize` rather than `reinitilize`. - Should read `farthest` rather than `farest`. - Should read `commands` rather than `comamnds`. * Update core.py * async_cluster: fix concurrent pipeline (#2280) - each pipeline should create separate stacks for each node * Add support for TIMESERIES 1.8 (#2296) * Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters * Remove verbose logging from `redis-py/redis/cluster.py` (#2238) * removed the logging module and its corresponding methods * updated CHANGES * except block for RedisClusterException and BusyLoadingError removed * removed unused import (redis.exceptions.BusyLoadingError) * empty commit to re-trigger Actions workflow * replaced BaseException with Exception * empty commit to re-trigger Actions workflow * empty commit to re-trigger Actions workflow * redundant logic removed * re-trigger pipeline * reverted changes * re-trigger pipeline * except logic changed * redis stream example (#2269) * redis stream example * redis stream example on docs/examples.rst Co-authored-by: pedro.frazao <perl.pf@netcf.org> * Fix: `start_id` type for `XAUTOCLAIM` (#2257) * Changed start_id type for xautoclaim * Added to changes Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * Doc add timeseries example (#2267) * DOC add timeseries example * DOC add timeseries examples * Apply suggestions * Fix typo Detention period => Retention period Co-authored-by: Gauthier Imbert <gauthier@PC17> * Fix warnings and resource usage problems in asyncio unittests (#2258) * Use pytest-asyncio in auto mode Remove overly genereric `pytestmark=pytest.mark.asyncio` causing lots of warning noise * Use "Factories as Fixtures" test pattern for the `create_redis` fixture this fixture is now async, avoiding teardown problems with missing event loops. * Fix sporadic error on fast event loops, such as `--uvloop` * Close connection, even if "username" was in kwargs This fixes a resource usage warning in the async unittests. * Do async cleanup of acl passwords via a fixture * Remove unused import, fix whitespace * Fix test with missing "await" * Close pubsub objects after use in unittest Use a simple fixture where possible, otherwise manually call pubsub.close() * re-introduce `pytestmark=pytest.mark.asyncio` for python 3.6 * Use context manager to clean up connections in connection pool for unit tests * Provide asynccontextmanager for python 3.6 * make `test_late_subscribe()` more robuste * Catch a couple of additional leaked resources * Graph - add counters for removed labels and properties (#2292) * grpah - add counters for removed labels and properties * added mock graph result set statistics * docstrings for graph result set statistics * format * isort * moved docstrings into functions * cleaning up the readme and moving docs into readthedocs (#2291) * cleaning up the readme and moving docs into readthedocs * examples at the end as per pr comments * async_cluster: fix max_connections/ssl & improve args (#2217) * async_cluster: fix max_connections/ssl & improve args - set proper connection_class if ssl = True - pass max_connections/connection_class to ClusterNode - recreate startup_nodes to properly initialize - pass parser_class to Connection instead of changing it in on_connect - only pass redis_connect_func if read_from_replicas = True - add connection_error_retry_attempts parameter - skip is_connected check in acquire_connection as it is already checked in send_packed_command BREAKING: - RedisCluster args except host & port are kw-only now - RedisCluster will no longer accept unknown arguments - RedisCluster will no longer accept url as an argument. Use RedisCluster.from_url - RedisCluster.require_full_coverage defaults to True - ClusterNode args except host, port, & server_type are kw-only now * async_cluster: remove kw-only requirement from client Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * fix review comments * fix * fix review comments * fix review comments Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: szumka <106675199+szumka@users.noreply.github.com> Co-authored-by: Mehdi ABAAKOUK <sileht@sileht.net> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Utkarsh Gupta <utkarshgupta137@gmail.com> Co-authored-by: Nial Daly <34862917+nialdaly@users.noreply.github.com> Co-authored-by: pedrofrazao <603718+pedrofrazao@users.noreply.github.com> Co-authored-by: pedro.frazao <perl.pf@netcf.org> Co-authored-by: Антон Безденежных <gamer392@yandex.ru> Co-authored-by: Iglesys <g.imbert34@gmail.com> Co-authored-by: Gauthier Imbert <gauthier@PC17> Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com> Co-authored-by: DvirDukhan <dvir@redis.com>

* Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters

* Add support for async graph * linters * fix docstring * Use retry mechanism in async version of Connection objects (#2271) * fix is_connected (#2278) * fix: workaround asyncio bug on connection reset by peer (#2259) Fixes #2237 * Fix crash: key expire while search (#2270) * fix expire while search * sleep * docs: Fix a few typos (#2274) * docs: Fix a few typos There are small typos in: - redis/cluster.py - redis/commands/core.py - redis/ocsp.py - tests/test_cluster.py Fixes: - Should read `validity` rather than `valididy`. - Should read `reinitialize` rather than `reinitilize`. - Should read `farthest` rather than `farest`. - Should read `commands` rather than `comamnds`. * Update core.py * async_cluster: fix concurrent pipeline (#2280) - each pipeline should create separate stacks for each node * Add support for TIMESERIES 1.8 (#2296) * Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters * Remove verbose logging from `redis-py/redis/cluster.py` (#2238) * removed the logging module and its corresponding methods * updated CHANGES * except block for RedisClusterException and BusyLoadingError removed * removed unused import (redis.exceptions.BusyLoadingError) * empty commit to re-trigger Actions workflow * replaced BaseException with Exception * empty commit to re-trigger Actions workflow * empty commit to re-trigger Actions workflow * redundant logic removed * re-trigger pipeline * reverted changes * re-trigger pipeline * except logic changed * redis stream example (#2269) * redis stream example * redis stream example on docs/examples.rst Co-authored-by: pedro.frazao <perl.pf@netcf.org> * Fix: `start_id` type for `XAUTOCLAIM` (#2257) * Changed start_id type for xautoclaim * Added to changes Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * Doc add timeseries example (#2267) * DOC add timeseries example * DOC add timeseries examples * Apply suggestions * Fix typo Detention period => Retention period Co-authored-by: Gauthier Imbert <gauthier@PC17> * Fix warnings and resource usage problems in asyncio unittests (#2258) * Use pytest-asyncio in auto mode Remove overly genereric `pytestmark=pytest.mark.asyncio` causing lots of warning noise * Use "Factories as Fixtures" test pattern for the `create_redis` fixture this fixture is now async, avoiding teardown problems with missing event loops. * Fix sporadic error on fast event loops, such as `--uvloop` * Close connection, even if "username" was in kwargs This fixes a resource usage warning in the async unittests. * Do async cleanup of acl passwords via a fixture * Remove unused import, fix whitespace * Fix test with missing "await" * Close pubsub objects after use in unittest Use a simple fixture where possible, otherwise manually call pubsub.close() * re-introduce `pytestmark=pytest.mark.asyncio` for python 3.6 * Use context manager to clean up connections in connection pool for unit tests * Provide asynccontextmanager for python 3.6 * make `test_late_subscribe()` more robuste * Catch a couple of additional leaked resources * Graph - add counters for removed labels and properties (#2292) * grpah - add counters for removed labels and properties * added mock graph result set statistics * docstrings for graph result set statistics * format * isort * moved docstrings into functions * cleaning up the readme and moving docs into readthedocs (#2291) * cleaning up the readme and moving docs into readthedocs * examples at the end as per pr comments * async_cluster: fix max_connections/ssl & improve args (#2217) * async_cluster: fix max_connections/ssl & improve args - set proper connection_class if ssl = True - pass max_connections/connection_class to ClusterNode - recreate startup_nodes to properly initialize - pass parser_class to Connection instead of changing it in on_connect - only pass redis_connect_func if read_from_replicas = True - add connection_error_retry_attempts parameter - skip is_connected check in acquire_connection as it is already checked in send_packed_command BREAKING: - RedisCluster args except host & port are kw-only now - RedisCluster will no longer accept unknown arguments - RedisCluster will no longer accept url as an argument. Use RedisCluster.from_url - RedisCluster.require_full_coverage defaults to True - ClusterNode args except host, port, & server_type are kw-only now * async_cluster: remove kw-only requirement from client Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * fix review comments * fix * fix review comments * fix review comments Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: szumka <106675199+szumka@users.noreply.github.com> Co-authored-by: Mehdi ABAAKOUK <sileht@sileht.net> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Utkarsh Gupta <utkarshgupta137@gmail.com> Co-authored-by: Nial Daly <34862917+nialdaly@users.noreply.github.com> Co-authored-by: pedrofrazao <603718+pedrofrazao@users.noreply.github.com> Co-authored-by: pedro.frazao <perl.pf@netcf.org> Co-authored-by: Антон Безденежных <gamer392@yandex.ru> Co-authored-by: Iglesys <g.imbert34@gmail.com> Co-authored-by: Gauthier Imbert <gauthier@PC17> Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com> Co-authored-by: DvirDukhan <dvir@redis.com>

dvora-h added 2 commits July 21, 2022 14:26

Add support for timeseries 1.8

74146f1

fix info

f622eb4

dvora-h changed the title ~~Add support for TIMESERIES 1.8 & cleanupdocstr~~ Add support for TIMESERIES 1.8 Jul 21, 2022

linters

5bacff0

dvora-h added help-wanted feature New feature breakingchange API or Breaking Change and removed help-wanted labels Jul 21, 2022

dvora-h added 2 commits July 21, 2022 14:39

linters

7558d2e

fix info test

5a76a09

dvora-h requested a review from chayim July 21, 2022 11:58

chayim reviewed Jul 21, 2022

View reviewed changes

redis/commands/timeseries/commands.py Outdated Show resolved Hide resolved

chayim reviewed Jul 21, 2022

View reviewed changes

redis/commands/timeseries/commands.py Show resolved Hide resolved

chayim reviewed Jul 21, 2022

View reviewed changes

tests/test_timeseries.py Show resolved Hide resolved

chayim reviewed Jul 21, 2022

View reviewed changes

redis/commands/timeseries/info.py Outdated Show resolved Hide resolved

dvora-h added 2 commits July 21, 2022 17:48

type hints

2c16dae

linters

32b33ed

dvora-h requested a review from chayim July 21, 2022 14:53

chayim approved these changes Jul 24, 2022

View reviewed changes

dvora-h merged commit 912accc into redis:master Jul 24, 2022

dvora-h added a commit to dvora-h/redis-py that referenced this pull request Jul 27, 2022

Add support for TIMESERIES 1.8 (redis#2296)

b12b025

* Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters

dvora-h added a commit that referenced this pull request Nov 21, 2022

Add support for TIMESERIES 1.8 (#2296)

2c13bb4

* Add support for timeseries 1.8 * fix info * linters * linters * fix info test * type hints * linters

dvora-h deleted the ts-1.8 branch June 18, 2023 00:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for TIMESERIES 1.8 #2296

Add support for TIMESERIES 1.8 #2296

Uh oh!

dvora-h commented Jul 21, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Jul 21, 2022 •

edited

Loading

Uh oh!

chayim Jul 21, 2022

Uh oh!

chayim Jul 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chayim Jul 21, 2022

Uh oh!

Uh oh!

Uh oh!

Add support for TIMESERIES 1.8 #2296

Add support for TIMESERIES 1.8 #2296

Uh oh!

Conversation

dvora-h commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request check-list

Description of change

Uh oh!

codecov-commenter commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chayim Jul 21, 2022

Choose a reason for hiding this comment

Uh oh!

chayim Jul 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chayim Jul 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dvora-h commented Jul 21, 2022 •

edited

Loading

codecov-commenter commented Jul 21, 2022 •

edited

Loading