/ redis-py Public
Remove redundant assignment to RedisCluster.nodes_manager. #2620
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Nothing grandiose, but can we just remove that line that keeps bugging me? I don't think assigning
Noneto the attribute, only to immediately assign a
NodeManagerinstance to the same one, has any meaningful effect, does it?
Of course I'm not adding this to my resume or anything.. just spotted the line while reading through and couldn't help but make a PR.