Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant assignment to RedisCluster.nodes_manager. #2620



Copy link

@thebarbershop thebarbershop commented Mar 15, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Nothing grandiose, but can we just remove that line that keeps bugging me? I don't think assigning None to the attribute, only to immediately assign a NodeManager instance to the same one, has any meaningful effect, does it?

Of course I'm not adding this to my resume or anything.. just spotted the line while reading through and couldn't help but make a PR.

@thebarbershop thebarbershop changed the title Remove redundant assignment. Remove redundant assignment to RedisCluster.nodes_manager. Mar 15, 2023
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.31 ⚠️

Comparison is base (6c708c2) 92.31% compared to head (824a5d5) 92.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2620      +/-   ##
- Coverage   92.31%   92.01%   -0.31%     
  Files         115      115              
  Lines       29744    29742       -2     
- Hits        27459    27367      -92     
- Misses       2285     2375      +90     
Impacted Files Coverage Δ
redis/ 90.41% <ø> (-0.02%) ⬇️

... and 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Mar 16, 2023
@dvora-h dvora-h merged commit 91ab12a into redis:master Mar 16, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
maintenance Maintenance (CI, Releases, etc)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants