[v22.3.x] Error checking pp json serialization #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit e098e2b)
Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit b688dc3)
Now detecting result of serialization to prevent assertion error if serialization continues without error checking. Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 988d598)
Added test that will submit base64 encoded binary data and then attempt to fetch it using JSON Accept headers Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 979f80b)
BenPope
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9867
Fixes #10037,