[v23.1.x] ducktape: use pgrep to find the redpanda process #11417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like redpanda_pid can pick up false pids in the current grep filtering approach. Use `pgrep` to not incorrectly pickup a command with a command line arg of `redpanda`, which seems likely in our environments. When debugging redpanda-data#11275, it seems like there is an apport process who's pid is being picked up. Here's a process dump that includes the line. There are no running redpanda processes, but checking for redpanda processes times out, leading me to believe that this process is being picked up. In that case `stop_node` can fail if the node is already failed in CDT, as this process is picked up. ``` [DEBUG - 2023-06-12 02:54:07,216 - redpanda - _log_node_process_state - lineno:2215]: root 136962 99.6 6.0 1587948 1452804 ? R 02:53 0:49 /usr/bin/python3 /usr/shar e/apport/apport -p136954 -s5 -c18446744073709551615 -d1 -P136954 -u0 -g0 -- !opt!redpanda_installs!head!libexec!redpanda ``` Fixes: redpanda-data#11275 Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 4a2985f)
andijcr
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11387
Fixes #11415,