v23.1.x: rpk minor bugs #11926
Merged
v23.1.x: rpk minor bugs #11926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if listing topics failed, we would panic * for printing by size, we should print descending similar to other CLI tools (cherry picked from commit 330566e)
* We should only request metadata for empty topics if we actually have empty topics. Requesting metadata with no empty topics requests metadata for the entire cluster, which results in offset-delete for all topics. * For parsing topic partition args, we need to `make` with 0 length. Accidentally using the capacity as length results in issuing metadata requests with empty topic names (which cropped up another bug in kadm, which will be fixed by a dep bump before the next release) (cherry picked from commit 726508d)
All errors were squashed into one line, these were meant to be split across lines (cherry picked from commit db33de1)
r-vasquez
approved these changes
Jul 6, 2023
|
These are bug fixes and there are no artifacts, a few core builds passed, two failed due to seemingly flakes -- merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #11900
Fixes a few bugs noticed while working on other things (so, not user reported). The offset-delete bugs are more important and exist in 23.1, so this should be backported. The logdirs panic is hard to hit (only encountered if the RP request fails) but is also worth backporting. The consume bug is just a display printing bug (errors are collapsed into one line).
Release Notes
Bug Fixes
rpk group offset-deleteno longer tries to delete offsets for all topics if no empty topics are specifiedrpk group offset-deleteno longer tries to delete offsets for empty-name topicsrpk cluster logdirsno longer panics if there is an error getting a response from Redpanda