[v23.1.x] admin_server/get_partition: Avoid oversized allocation #11928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
added
kind/backport
Avoid oversized allocation by: * Collecting summaries into a fragmented_vector * Streaming the vector to an output_stream The overload of `ss::json::json_return_type` that provides an `ss::output_stream` requires a `std::function`, which is required to be copyable, so wrap the `fragmented_vector` in a simple container wrapper that holds the container by `ss::lw_shared_ptr`. Another optimisation is moving rather than copying during accumulation. Fixes redpanda-data#11674 Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit d32b250) Conflicts: src/v/redpanda/admin_server.cc Due to 2cc38ee I took the opportunity to extract `reduce` and reuse it.
BenPope
force-pushed
the
backport-11824-v23.1.x
branch
from
1b95917 to
84ce4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11824
Fixes #11924
Conflicts:
src/v/redpanda/admin_server.cc
Due to 2cc38ee
I took the opportunity to extract
reduceand reuse it.Backports Required
Release Notes
Improvements