[v23.1.x] kafka: Disable use of separate fetch scheduling group #12035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 9a93a9c While the original motiviation isn't invalidated we have now found a counter example where the extra fetch groups makes things worse overall. `ManyPartitionTest` fails on ARM with the extra group but passes without. With the group in use CPU util hits 100% and grinds everything to halt. Fetch seems to be a lot slower on ARM. Hence, with the guaranteed share of the extra group the whole system gets affected and hits CPU limits. Because this is incredibly hard to reason about and it wasn't the core fetch optimization we decided to revert back to keeping it disabled by default. We still keep the option around as it might be useful potentially in corner cases. Fixes redpanda-data#10507 (cherry picked from commit 6d1223d)
StephanDollberg
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #11919
Fixes: #12034,