Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] cluster/topics_frontend: Move some topic preprocessing into create_topics #13853

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[v23.2.x] cluster/topics_frontend: Move some topic preprocessing into create_topics #13853

merged 2 commits into from
Oct 2, 2023

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Oct 1, 2023

Backport of PR #13657

@oleiman
cluster/topics_frontend: Move topic preprocessing into create_topics
3111c46 
Adds `shadow_indexing` and `cleanup_policy_bitflags` default fallback to
`create_topics`.

Also plumbs the `metadata_cache` down into `topics_frontend` for this
purpose, and in case we need to add more property fallbacks in the future.

This commit also relaxes an assertion in a fixture test [1] to account for
some additional requests during topic recovery when the test topic has
cloud storage switched on.

[1] `cloud_storage_rpfixture::topic_recovery_service_test.recovery_with_existing_topic`

(cherry picked from commit c417dba)
@oleiman
tests/topic_creation_test: TopicAutocreateTest with SI
b4954c3 
(cherry picked from commit 7106d1d)
@oleiman oleiman added this to the v23.2.x-next milestone Oct 1, 2023
@oleiman oleiman added the kind/backport PRs targeting a stable branch label Oct 1, 2023
@mergify
Copy link

mergify bot commented Oct 1, 2023

⚠️ The sha of the head commit of this PR conflicts with #13848. Mergify cannot evaluate rules on this PR. ⚠️

@oleiman oleiman marked this pull request as ready for review October 1, 2023 19:50
@oleiman
Copy link
Member Author

oleiman commented Oct 2, 2023

CI Failures:

@oleiman oleiman merged commit 2d5938e into redpanda-data:v23.2.x Oct 2, 2023
@RafalKorepta RafalKorepta modified the milestones: v23.2.x-next, v23.2.12 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andijcr andijcr andijcr approved these changes

@abhijat abhijat Awaiting requested review from abhijat

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.2.12
Development

Successfully merging this pull request may close these issues.
3 participants
@oleiman @andijcr @RafalKorepta