[v23.2.x] k/protocol && utils/fragmented_vector improvements #13881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 239a9f0)
Operator added in redpanda-data#11691 Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit a2b9966)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit ceab400)
This is a pure refactor which will make it easier to keep them in sync. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 3790e24)
Pure refactor to simplify the logic of calling the various read_array types. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 2c4d1fa)
Construct a large_fragment_vector during read_array for types listed in `enable_fragmentation_resistance`, which is currently `metadata_response_partition`. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit ef092e6)
Assignment from `std::vector` was introduced in redpanda-data#8469. Now that kafka/protocol/generator can call kafka::protocol::read_array<fragmented_vector>, this is no longer needed, avoiding a large copy. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit bc63e9f)
BenPope
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #13854