-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.2.x] log_manager::housekeeping_scan iteration with suspension point fix #13893
Merged
piyushredpanda
merged 7 commits into
redpanda-data:v23.2.x
from
andijcr:vbotbuildovich/backport-13615-v23.2.x-855
Oct 4, 2023
Merged
[v23.2.x] log_manager::housekeeping_scan iteration with suspension point fix #13893
piyushredpanda
merged 7 commits into
redpanda-data:v23.2.x
from
andijcr:vbotbuildovich/backport-13615-v23.2.x-855
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnwat
approved these changes
Oct 3, 2023
https://buildkite.com/redpanda/redpanda/builds/38169#018af535-9f5c-459f-8e51-c9152ae185eb
And it's new. I will ask @abhijat for input on this. in the meantime, the next force push is to fix a merge conflict |
to use in housekeeping scan for time-based segment rolling with segment_ms
this is done to sidestep iterator invalidation that could happen during the suspension point while co_awaiting for apply_segment_ms. to do so, the while loops until it reaches a log that is already marked with bflags::lifetime_checked. in the loop, current log is marked, list is rotated for the next loop, and apply_segment_ms is awaited.
empty bouncer check is redundant, the rest of the function can cope with an empty _logs_list
f413202
to
f9afb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #13615
Fixes #13830