Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk,k8s: bump franz-go to v1.12.0 for bugfixes #8793

Merged
merged 1 commit into from
Mar 1, 2023
Merged

rpk,k8s: bump franz-go to v1.12.0 for bugfixes #8793

merged 1 commit into from
Mar 1, 2023

Conversation

twmb
Copy link
Contributor

@twmb twmb commented Feb 10, 2023 •
edited
Loading

Release notes

Bug fixes

  • Bumps the franz-go dep to pull in bug fixes, notably the Record.TimestampDelta varint => varlong fix

@twmb twmb requested review from 0x5d, r-vasquez and a team as code owners February 10, 2023 15:25
@twmb twmb force-pushed the v22.2.x-franz-bump branch from 5e517d3 to 76c1b6b Compare February 10, 2023 15:31
RafalKorepta
RafalKorepta reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why go.mod in src/go/k8s is not changed/commited?

@twmb
Copy link
Contributor Author

twmb commented Feb 10, 2023

It's not depended on in k8s, but probably because k8s uses rpk code directly with a replace directive

@RafalKorepta
Copy link
Contributor

@twmb In the #8792 there is change in k8s/go.mod https://github.com/redpanda-data/redpanda/pull/8792/files#diff-c266f48115010d948343135c364a5768282873df67baaffdb9c744a4aa0c33f7R22

That's why I'm confused.

@twmb
Copy link
Contributor Author

twmb commented Feb 10, 2023

No idea either. go mod tidy strips it even if I manually add it.

@joejulian joejulian merged commit e43d798 into redpanda-data:v22.2.x Mar 1, 2023
This was referenced Mar 14, 2023
Closed
Closed
Closed
Merged
@twmb twmb deleted the v22.2.x-franz-bump branch April 6, 2023 14:08
@twmb twmb restored the v22.2.x-franz-bump branch April 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalKorepta RafalKorepta RafalKorepta approved these changes

@r-vasquez r-vasquez r-vasquez approved these changes

@0x5d 0x5d Awaiting requested review from 0x5d

Assignees
No one assigned
Labels
area/k8s area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twmb @RafalKorepta @r-vasquez @joejulian