Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] cluster: fix a case where version updates weren't generated #8988

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[v22.3.x] cluster: fix a case where version updates weren't generated #8988

merged 1 commit into from
Apr 12, 2023

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #8902
Fixes #8987,

@jcsp @vbotbuildovich
cluster: fix sometimes missing node version updates
1d9b55c 
Calculating deltas on health reports was not robust,
because after a leadership change theq controller can come
up on a node that already has a health report showing
a newer version, i.e. no delta wrt the next report.

Instead, generate an update to _node_versions whenever
we see a version that is newer than that in the map, and
clear _node_versions on leadership/term changes.  This
guarantees that within each controller term, we will
pay attention to node versions from all nodes until we
have accumulated a version from each node, and thereafter
we will only submit updates if the version in a health
report is newer than the one in _node_versions.

Fixes: redpanda-data#8758
(cherry picked from commit f54c7c9)
@vbotbuildovich vbotbuildovich added this to the v22.3.x-next milestone Feb 20, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Feb 20, 2023
@jcsp jcsp marked this pull request as ready for review February 28, 2023 13:26
@jcsp
Copy link
Contributor

jcsp commented Feb 28, 2023

Failure appears unrelated:

@jcsp jcsp requested a review from mmaslankaprv February 28, 2023 13:39
@piyushredpanda piyushredpanda modified the milestones: v22.3.x-next, v22.3.14 Feb 28, 2023
@vshtokman vshtokman modified the milestones: v22.3.14, v22.3.x-next Mar 3, 2023
@BenPope
Copy link
Member

BenPope commented Apr 4, 2023

Ping

@piyushredpanda piyushredpanda modified the milestones: v22.3.x-next, v22.3.16 Apr 10, 2023
@vshtokman vshtokman requested a review from dotnwat April 11, 2023 07:41
@jcsp jcsp merged commit 82eeaf9 into redpanda-data:v22.3.x Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees

@jcsp jcsp

Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.3.16
Development

Successfully merging this pull request may close these issues.
5 participants
@vbotbuildovich @jcsp @BenPope @vshtokman @piyushredpanda