[v22.2.x] cluster: fix a case where version updates weren't generated #8990
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating deltas on health reports was not robust, because after a leadership change theq controller can come up on a node that already has a health report showing a newer version, i.e. no delta wrt the next report. Instead, generate an update to _node_versions whenever we see a version that is newer than that in the map, and clear _node_versions on leadership/term changes. This guarantees that within each controller term, we will pay attention to node versions from all nodes until we have accumulated a version from each node, and thereafter we will only submit updates if the version in a health report is newer than the one in _node_versions. Fixes: redpanda-data#8758 (cherry picked from commit f54c7c9)
andrwng
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #8902
Fixes #8989,