[v22.2.x] Backport #9105 bugfix #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the value of `_name` was passed into `on_stopped`. This is a
problem in the case of an unnamed consumer because `_name` will be an
empty string. Instead, use the result of `consumer::name()`.
Here is the definition of `on_stopped`:
```cpp
auto on_stopped = [this, group_id](const member_id& name) {
_consumers[group_id].erase(name); // silenty fails if name is empty
};
```
The result of passing an empty string to `on_stopped` is that the
consumer is not erased from the map. This is an issue because the client
expects the map to eventually become empty.
From `client::stop()`:
```cpp
for (auto& [id, group] : _consumers) {
while (!group.empty()) { // group is never empty, so infinite loop
auto c = *group.begin();
co_await catch_and_log([c]() {
return c->leave();
});
}
}
```
Instead, the while loop becaomes an inifite loop since the consumer is
never removed.
Fixes redpanda-data#9310
(cherry picked from commit 791cf6e)
BenPope
added
area/pandaproxy
NyaliaLui
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9105 to branch v22.2.x. (just the bugfix)
Fixes #9310