[v22.3.x] archival: lock segments before opening readers #9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A read lock is placed on any segment that the cloud storage upload loop selects: compacted or not. The upload loop needs to convert the begin and end offsets into the segments to file offsets for partial uploads. Previously, in the case of compacted segment reuploads, the locks were taken after the conversion to file offsets. When we couple this with the fact that compacted re-uploads can occur below the latest disk log start offset, it meant that the segment could be removed with an outstanding reader before the locks were acquired. This bubbled up and stopped the upload loop with "Bad file descriptor" errors. This commit fixes the issue by taking the locks before any readers are created. Note that the non-compacted upload path does the same thing. (cherry picked from commit f87763a)
VladLazar
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9566
Fixes #9579,