[v22.3.x] schema_registry: Allow a schema id and version to be supplied #9828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 5b2e693)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit f037a3e)
…schema` Allow a schema id and version to passed through from the handler to the store. A future commit will wire this up. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit c210e75) minor conflict in sharded_store.cc includes due to removal of <seastar/core/std-coroutine.hh>
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit ab89709) Minor conflict in post_subject_versions.cc due to addition of NOLINT
Helpers for * Setting an subject config * Extracting an error_body from a response Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 1b0b338)
Schema registry has been properly sharded for a long time now, run the fixture tests with the default number of cores. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 046e0ab)
Providing a schema id allows migration from another Schema Registry, and should only be allowed during import. The Schema Registry does not yet support setting the mode (`PUT /mode`, `PUT /mode/subject`), not does it support the `IMPORT` mode, so that is not checked. If an id for a schema is provided, then the schema must either not already exist, or the id must match the existing one. If an id is not provided, the existing behaviour is retained; if the schema does not already exist, an id is allocated for it, otherwise the existing id is returned. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 2821c71)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit c0260a5)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 21cc759)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 43609c0)
When inserting a `schema`, if a `schema_version` is provided, use it. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 09527a1)
michael-redpanda
approved these changes
Apr 6, 2023
BenPope
added
area/schema-registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9691
Fixes #9825,