[v22.3.x] cloud_storage: Read path hardening #9872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method removes all items fromt he offset translator. (cherry picked from commit 26be2ba)
...translation inconsistencies. The problem can arise if the partition was restored. In this case the segment uploaded by the new cluster will have 'offset_delta' field smaller than in the segments uploaded by the old cluster. The fix updates read path to handle this situation by stopping iteration when the reader reaches the 'seam' between data uploaded by the old cluster and the new cluster. The reader uses two strategies: - if no data was produced by the reader it just resets the ot_state; - otherwise it stops current reader and returns; (cherry picked from commit 37d5283)
VladLazar
reviewed
Apr 6, 2023
VladLazar
approved these changes
Apr 6, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #9865
In the restored partition the delta-offset values of uploaded segments will reset and stop being monotonic. This breaks our read path because the
offset_translator_stateinstance is crated per fetch request and every fetch request can read from more than one segment. If the partition reader reads from two segments and the second segment has delta offset which is lower than delta offset of the previous segment theoffset_translator_statewill throw.To avoid this the reader detects this situation and exits early or resets the
offset_translator_state.Backports Required
Release Notes
Bug Fixes