Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.3.x] r/configuration_manager: add highest_known_offset checkpoint mutex #9962

Merged
merged 2 commits into from
Apr 13, 2023
Merged

[v22.3.x] r/configuration_manager: add highest_known_offset checkpoint mutex #9962

merged 2 commits into from
Apr 13, 2023

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Apr 11, 2023

Backport of PR #9827

ztlpn added 2 commits April 11, 2023 15:59
@ztlpn
r/configuration_manager: prevent concurrent checkpoint attempts
c37dade 
Previously, several background fibers spawned by consensus::disk_append
could run configuration_manager::maybe_store_highest_known_offset in
parallel. Because the storage_resources units were not released until we
actually finished the kvstore write, every bg fiber launched during the
kvstore debounce period will do a kvstore write on its own. This commit
adds a flag that makes sure that we do only one checkpoint at a time.

Fixes redpanda-data#9309

(cherry picked from commit 17df605)
@ztlpn
r/offset_translator: skip concurrent checkpoint attempts
719aa88 
(cherry picked from commit ec8f387)
@ztlpn ztlpn added this to the v22.3.x-next milestone Apr 11, 2023
@ztlpn ztlpn requested review from dotnwat, jcsp and mmaslankaprv April 11, 2023 13:17
@ztlpn
Copy link
Contributor Author

ztlpn commented Apr 12, 2023

Test errors:

@ztlpn
Copy link
Contributor Author

ztlpn commented Apr 12, 2023

one more error:

@ztlpn ztlpn merged commit 5698842 into redpanda-data:v22.3.x Apr 13, 2023
@vshtokman vshtokman modified the milestones: v22.3.x-next, v22.3.16 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

@jcsp jcsp Awaiting requested review from jcsp

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
v22.3.16
Development

Successfully merging this pull request may close these issues.
3 participants
@ztlpn @mmaslankaprv @vshtokman