Skip to content

Conversation

nickserv
Copy link
Contributor

@nickserv nickserv commented Sep 17, 2021

Should work since Travis was using Ubuntu previously

@Methuselah96
Copy link
Member

I'm curious to see if this works. IIRC the E2E extension tests were not able to run successfully when I which is why I ended up switching to Windows. I'm sure there's a way to do it (probably involving setting up xvfb) but it was easier just to switch to Windows at the time.

@nickserv
Copy link
Contributor Author

nickserv commented Sep 17, 2021

If that ends up being the case, it might be better to have the E2E tests in a separate job. Alternatively if you prefer xvfb we can try to get it to work based on the old Travis config or custom GitHub Actions.

@Methuselah96
Copy link
Member

Methuselah96 commented Sep 17, 2021

Yeah, the old repo was using AppVeyor (Windows), presumably for the same reason.

@Methuselah96
Copy link
Member

Methuselah96 commented Sep 17, 2021

I'm okay with a separate job, but there would definitely be duplicate work since the E2E tests rely on building almost all of the packages which is the slowest part of the build, but I suppose it would overall be faster if the Windows didn't have to run the other stages of the build as well. My preference would be to get the E2E tests working on Linux using GitHub Actions.

@nickserv
Copy link
Contributor Author

That sounds good, but the build is still failing on the lint step. Any idea why?

@Methuselah96
Copy link
Member

#867 should fix the lint.

@Methuselah96
Copy link
Member

Hope you don't mind I added to the PR. Thanks for you work on this!

@Methuselah96 Methuselah96 merged commit 7c9579c into reduxjs:main Sep 18, 2021
@nickserv nickserv deleted the build-on-linux branch September 18, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants