Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed oazapfts typescript version in rtk-query-codegen-openapi #3771

Closed
wants to merge 1 commit into from

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Oct 3, 2023

#3765

The reason for this is that codegen's TypeScript version was 4.5, but oazapfts' TypeScript version was 4.9.2, which broke compatibility.

To fix this problem, it would be best to use the resolution field and fix the oazapfts TypeScript version to the user's TypeScript version.

The test timed out, so the test time was extended.
https://github.com/reduxjs/redux-toolkit/actions/runs/6388673287/job/17338896802

@codesandbox
Copy link

codesandbox bot commented Oct 3, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 19114de
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/651b9e099e4c7c000876aeed
😎 Deploy Preview https://deploy-preview-3771--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kahirokunn kahirokunn force-pushed the fixed-ts-version branch 2 times, most recently from 4673761 to a3d2856 Compare October 3, 2023 04:20
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19114de:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@kahirokunn
Copy link
Contributor Author

@phryneas
Hello!
I would be happy if you could review this when you have time.

@phryneas
Copy link
Member

phryneas commented Oct 3, 2023

Hey @kahirokunn, resolutions won't help here for the npm package, as package mangers will ignore that field when installing a dependency. It seems like we'd need to upgrade the codegen to support newer TS versions. I know that @msutkowski wanted to go through a bunch of open PRs, but I'm not sure if that was also on his codegen-related TODO list. Maybe the two of you could coordinate a bit?

@kahirokunn
Copy link
Contributor Author

@msutkowski Hello.
How do you plan to tackle this issue?

@phryneas
Copy link
Member

Seems like the TS update has already happened - closing :)

@phryneas phryneas closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants