-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fixed oazapfts typescript version in rtk-query-codegen-openapi #3771
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
1cbf0dc
to
d35d247
Compare
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4673761
to
a3d2856
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19114de:
|
5c316d2
to
19114de
Compare
@phryneas |
Hey @kahirokunn, resolutions won't help here for the npm package, as package mangers will ignore that field when installing a dependency. It seems like we'd need to upgrade the codegen to support newer TS versions. I know that @msutkowski wanted to go through a bunch of open PRs, but I'm not sure if that was also on his codegen-related TODO list. Maybe the two of you could coordinate a bit? |
@msutkowski Hello. |
Seems like the TS update has already happened - closing :) |
#3765
The reason for this is that codegen's TypeScript version was 4.5, but oazapfts' TypeScript version was 4.9.2, which broke compatibility.
To fix this problem, it would be best to use the resolution field and fix the oazapfts TypeScript version to the user's TypeScript version.
The test timed out, so the test time was extended.
https://github.com/reduxjs/redux-toolkit/actions/runs/6388673287/job/17338896802