Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking a descript.ion file for a virtual folder (home) doesn't work #662

Closed
jbrown123 opened this issue Jul 1, 2024 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@jbrown123
Copy link

BEFORE

  • Are you using a reverse-proxy, like nginx?

Not using, doesn't matter

To Reproduce
Steps to reproduce the behavior:
Create a link to an on-disk file named descript.ion in a virtual folder (I did it in home)
Note that the file or folder doesn't have a comment in the web UI

Describe the bug
The descript.ion file is not read / processed / used in a virtual folder

Expected behavior
I expect the descript.ion file linked in the virtual folder to work just as it works in a real on-disk folder

Screenshots
Not really applicable here

Environment (please complete the following information):

  • OS: Windows 10, 64 bit
  • HFS Version 0.52.9 (latest stable)
  • Browser chrome (doesn't matter)

Additional context
Is there some other way, without making home (or other virtual folders) an on-disk folder, to get descriptions to work?

Can we just restore the (much better) comment functionality from the v2 HFS?
image

@jbrown123 jbrown123 added the bug Something isn't working label Jul 1, 2024
@rejetto
Copy link
Owner

rejetto commented Jul 1, 2024

so, what you are trying to do, is to have comments for items inside a virtual folder (like your home).
While I see the sense in your attempt, I think it's better to have something similar to hfs2, with the comment that can be set from the VFS itself.

@rejetto rejetto added enhancement New feature or request and removed bug Something isn't working labels Jul 1, 2024
@jbrown123
Copy link
Author

jbrown123 commented Jul 1, 2024

Yes, please!

I'd MUCH prefer to have the comment functionality from v2 ported to v3!

That said, I still believe this is a bug since it doesn't operate consistently between virtual & physical folders.

rejetto added a commit that referenced this issue Jul 7, 2024
rejetto added a commit that referenced this issue Jul 9, 2024
@rejetto
Copy link
Owner

rejetto commented Jul 10, 2024

this is ready for 0.54

rejetto added a commit that referenced this issue Jul 17, 2024
rejetto added a commit that referenced this issue Jul 19, 2024
rejetto added a commit that referenced this issue Jul 20, 2024
@rejetto
Copy link
Owner

rejetto commented Jul 20, 2024

version 0.54.0-alpha1 is out and includes this

@rejetto rejetto closed this as completed Jul 20, 2024
@jbrown123
Copy link
Author

Comments attached to links don't work. The comment is never displayed.

    - name: HFS - link to website
      url: https://www.rejetto.com/hfs/
      icon: link
      comment: Link to the HFS homepage

image

Here you can see that the comment worked for the local file (HFS - http file server (executable)) entry, but not for the link entry below that.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants