This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
[test] Import fixtures that mirror Flow tests upstream. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
commented
Jan 16, 2018
| export interface InputHasArrayVariables { | ||
| input?: { | ||
| clientMutationId?: string | null; | ||
| storyIds?: ReadonlyArray<string | null> | null; |
There was a problem hiding this comment.
Note the ReadonlyArray here.
|
Thanks! This looks great! I was thinking I'd have to take a look at how to best import the test fixtures from the compiler and get a working test setup, now that the focus goes away from getting some proof of concept into writing proper quality production grade code. I haven't had a decent look into how the test setup is done in the relay-compiler codebase. I figure getting a proper test setup working should be priority number 1 when working on the plugin. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to copy the test fixtures I made while working on my Babel7 approach and mirror exactly the Flow ones. I’m sure they’ll need some adjusting for how we’ll be defining types, but could be helpful as a guidance.