Fix map_to_s3 configuration #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negillett
force-pushed
the
fix_map_to_s3_config
branch
2 times, most recently
from
840476f to
e492fb0
Compare
negillett
commented
Feb 20, 2020
Environment variables are not supported by Lambda@Edge, so replace their usage with a configuration file. A JSON format file was chosen to prevent additional dependencies. Also, the transformed URI is now prepended with a forward-slash, "/", to correct the path to the file object. Tests were updated to reflect these changes. Fixes #8, fixes #10
negillett
force-pushed
the
fix_map_to_s3_config
branch
from
e492fb0 to
0647dd2
Compare
crungehottman
approved these changes
Feb 21, 2020
crungehottman
approved these changes
Feb 21, 2020
rohanpm
suggested changes
Feb 24, 2020
This commit moves the lambda function into a class so that objects can be reused if multiple events are received while the AWS Lambda container is still active.
rohanpm
approved these changes
Feb 25, 2020
This commit includes some touch-ups to in-line comments and log messages, moves some variables, and cleans up a couple of leftover print functions used in development.
Member
Author
|
Will go ahead with merge, as new changes are minor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables are not supported by Lambda@Edge, so replace their
usage with a configuration file. A JSON format file was chosen to
prevent additional dependencies.
Also, the transformed URI is now prepended with a forward-slash, "/", to
correct the path to the file object.
Tests were updated to reflect these changes.
Fixes #8, fixes #10