Add Lambda function redirecting URIs to S3 file objects #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the Lambda function module map_to_s3, which redirects an origin request URI to point to the corresponding S3 file object.
negillett
force-pushed
the
function-map-to-s3
branch
from
335d199 to
55974ee
Compare
Moves the formerly global environment variables into the function definition, as they weren't needed globaly and posed challenges in testing. This commit also make minor changes to logging messages and adds a return response in the event an invalid table item is received from the DB query.
This commit provides auto-tests for map_to_s3.py and includes a correction to the invalid item response body.
rohanpm
suggested changes
Feb 13, 2020
This commit changes the generated timestamp to full ISO8601 datetime, i.e., "2020-02-17T00:00:00.000+00:00".
These aren't particularly useful, as they only ensure that the call was constructed correctly, so remove them.
negillett
force-pushed
the
function-map-to-s3
branch
from
34b4ea1 to
da40a2f
Compare
Previously only KeyErrors were caught and a specific error message was logged before returning a 500 status. This commit has all exceptions caught, logging a more generic message before raising the exception.
negillett
force-pushed
the
function-map-to-s3
branch
from
da40a2f to
1221983
Compare
This commit creates documentation pages for the map_to_s3 function and its required DynamoDB and S3 schemas
negillett
requested review from
crungehottman,
dichn,
rajulkumar and
rohanpm
rohanpm
approved these changes
Feb 19, 2020
crungehottman
approved these changes
Feb 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits relating to redirecting URI origin requests to S3 file object keys.