Skip to content

build(package): make @types/react an optional peerDependency #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Feb 27, 2024

What is the motivation for this pull request?

build(package): make @types/react an optional peerDependency

Release-As: 5.1.8

What is the current behavior?

@types/react is a required dependency

What is the new behavior?

@types/react is an optional peerDependency

Checklist:

@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Feb 27, 2024
@remarkablemark remarkablemark self-assigned this Feb 27, 2024
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.17 KB (0%) 184 ms (0%) 49 ms (+17.33% 🔺) 232 ms

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1d33c0e) to head (8be504c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit ed07a62 into master Feb 27, 2024
@remarkablemark remarkablemark deleted the build/package branch February 27, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant